8000 Updated typings for ServiceMethods by deskoh · Pull Request #1409 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

Updated typings for ServiceMethods #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 15 commits into from
Jul 3, 2019
Merged

Updated typings for ServiceMethods #1409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f4eb90b
Typings fix and improvements.
deskoh May 23, 2019
28f0a44
Typo fix.
deskoh May 23, 2019
e4b77e9
Improved typings.
deskoh May 23, 2019
7e2f34d
Fixed tests.
deskoh May 23, 2019
a1ec135
Fixed tests by generalizing ServiceTypes
deskoh May 26, 2019
06d59de
Updated types for declaration merging.
deskoh May 26, 2019
fe42940
Updated tests.
deskoh May 26, 2019
d6c20c8
Updated Application.services
deskoh May 26, 2019
ce39544
Merge upstream master.
deskoh May 27, 2019
06f6204
Merge branch 'master' into master
daffl May 31, 2019
511d02e
Merge https://github.com/feathersjs/feathers
deskoh Jun 1, 2019
1e0773b
Merge https://github.com/feathersjs/feathers
deskoh Jun 19, 2019
482a199
Updated typings for ServiceMethods
deskoh Jun 19, 2019
daa5cc2
Fix broken build
deskoh Jun 28, 2019
c181266
Merge branch 'master' into master
daffl Jul 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/authentication/src/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Params, ServiceMethods } from '@feathersjs/feathers';

const debug = Debug('@feathersjs/authentication/service');

export class AuthenticationService extends AuthenticationBase implements ServiceMethods<AuthenticationResult> {
export class AuthenticationService extends AuthenticationBase implements Partial<ServiceMethods<AuthenticationResult>> {
/**
* Return the payload for a JWT based on the authentication result.
* Called internally by the `create` method.
Expand Down
15 changes: 6 additions & 9 deletions packages/feathers/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,23 +137,20 @@ declare namespace createApplication {
finally?: Partial<HookMap> | Hook | Hook[];
}

// todo: figure out what to do: These methods don't actually need to be
// implemented, so they can be undefined at runtime. Yet making them
// optional gets cumbersome in strict mode.
interface ServiceMethods<T> {
[key: string]: any;

find? (params?: Params): Promise<T | T[] | Paginated<T>>;
find (params?: Params): Promise<T | T[] | Paginated<T>>;

get? (id: Id, params?: Params): Promise<T>;
get (id: Id, params?: Params): Promise<T>;

create? (data: Partial<T> | Array<Partial<T>>, params?: Params): Promise<T | T[]>;
create (data: Partial<T> | Array<Partial<T>>, params?: Params): Promise<T | T[]>;

update? (id: NullableId, data: T, params?: Params): Promise<T>;
update (id: NullableId, data: T, params?: Params): Promise<T>;

patch? (id: NullableId, data: Partial<T>, params?: Params): Promise<T>;
patch (id: NullableId, data: Partial<T>, params?: Params): Promise<T>;

remove? (id: NullableId, params?: Params): Promise<T>;
remove (id: NullableId, params?: Params): Promise<T>;
}

interface SetupMethod {
Expand Down
0