3.2.0 and 3.2.1 packages include a nested node_modules/ directory with commons #1000
Description
It seems that both the 3.2.0 and 3.2.1 packages for feathersjs/feathers include a node_modules directory
Steps to reproduce
- Install either 3.2.0 or 3.2.1 of
@feathersjs/feathers
Expected behavior
- Expected just the
lib/directory and some other bits to be in the package
Actual behavior
tyler master … node_modules @feathersjs feathers pwd
/home/tyler/source/github/jenkins-infra/evergreen/distribution/client/node_modules/@feathersjs/feathers
tyler master … node_modules @feathersjs feathers tree node_modules
node_modules
└── @feathersjs
└── commons
├── CHANGELOG.md
├── lib
│ ├── commons.js
│ ├── filter-query.js
│ ├── hooks.js
│ ├── test
│ │ ├── client.js
│ │ └── fixture.js
│ └── utils.js
├── LICENSE
├── package.json
└── README.md
4 directories, 10 files
This seems to be the root cause of a wacky issue when I end up running my application which imports @feathersjs/feathers
info: Checking registration status..
debug: Writing public key to /evergreen/keys/evergreen.pub
debug: Writing private key to /evergreen/keys/evergreen-private-key
info: Creating registration..
error: Failed to register: message=Cannot read property 'eventMappings' of undefined, stack=TypeError: Cannot read property 'eventMappings' of undefined
at Object.<anonymous> (/evergreen/client/node_modules/@feathersjs/feathers/lib/events.js:9:27)
at promise.then.hookObject (/evergreen/client/node_modules/@feathersjs/feathers/node_modules/@feathersjs/commons/lib/hooks.js:142:73)
at process._tickCallback (internal/process/next_tick.js:68:7)
at Function.Module.runMain (internal/modules/cjs/loader.js:745:11)
at startup (internal/bootstrap/node.js:266:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:596:3), pubKey=04abe001df28c407485b2933027ab2f5145d08539f35d7dcec7510ea0608d51e82a266b7d8439f2d458bd68e96e35f1262ae5725da4bf563471974547f2ffe1381, curve=secp256k1, method=create, path=null, type=error, $ref=$["hook"]["0"], method=create, path=null, $ref=$["hook"]
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! evergreen-client@1.0.0 client: `node src/client.js`
npm ERR! Exit status 1
System configuration
Tell us about the applicable parts of your setup.
Module versions (especially the part that's not working):
NodeJS version: 10
Operating System: Linux
Browser Version:
React Native Version:
Module Loader: