8000 Bring back support of Ruby 2.3, 2.4 and 2.5 by torresga · Pull Request #155 · fastruby/next_rails · GitHub
[go: up one dir, main page]
Skip to content

Bring back support of Ruby 2.3, 2.4 and 2.5 #155

N 8000 ew issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bring back support of Ruby 2.3, 2.4 and 2.5 #155

wants to merge 5 commits into from
+8 −5

Conversation

torresga
Copy link
@torresga torresga commented May 16, 2025 •
edited
Loading

Description

This PR attempts to add back support of Ruby 2.3, 2.4, and 2.5 as requested in #135.

To add back the support for the older Ruby versions, I had to make the following changes:

  • Several months ago, rexml was updated in this commit e50e05a . I had to downgrade it to 3.2.5, as 3.2.6 and above set Ruby 2.5 as the minimum requirement as seen in rexml’s gemspec ruby/rexml@072b02f.
  • We added Ruby 3.4 support in February: 816e5b6 by updating webmock to 3.20.0. webmock version 3.20.0 is incompatible with Ruby versions below 2.5. To keep support for both Ruby 3.4 and Ruby 2.5 and below, I decided to downgrade webmock back to its' previous version and added base64 as a dependency in the gemspec.
  • We had a few instances of match?. match? wasn’t added until Ruby 2.4. I replaced those instances with match, which is also compatible with Ruby 2.3.

Motivation and Context

How Has This Been Tested?

Ruby 2.3 and 2.4 have been added to the CI and the tests pass in all versions.

Screenshots:

I will abide by the code of conduct

@torresga torresga changed the title Adds back old ruby versions Bring back support of Ruby 2.3, 2.4 and 2.5 May 16, 2025
@torresga torresga marked this pull request as ready for review May 20, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@torresga
0