Merged
Conversation
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/bump-v0.4.0 |
Member
Author
|
For some reason the cmap is wrapping around for the histogram colorbar on github actions, this isn't happening locally on my computer :/ . I'm on latest pygfx@main and wgpu The place the arrow is pointing to should be black:
|
Member
Author
|
ok something weird going on with texture cmap wrapping, the background in the "selected" subplot is supposed to be dark blue/purple for low value in viridis: https://www.fastplotlib.org/ver/bump-v0.4.0/_gallery/selection_tools/fft.html#sphx-glr-gallery-selection-tools-fft-py |
Member
Author
|
posted at pygfx/pygfx#979 |
Member
Author
|
@clewis7 I say let's merge in the meantime? |
clewis7
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.