Improvements to GUI selection and Qt support#431
Improvements to GUI selection and Qt support#431kushalkolar merged 9 commits intofastplotlib:mainfrom
Conversation
|
Ready for review, but I figure you may want to have a code-review before letting CI run 😄 |
|
Funny how pygfx/pygfx#674 gets reported while we're working on this 😄 I think I'll put this PR on hold, and first address the GUI backend selection mechanics. I think your code to check what GUI Jupyter has integrated should be used in wgpu-py. And perhaps it makes sense to provide more ways to influence backend preference, that fpl can then use (in the new |
|
yup makes sense to do it upstream, less wheel reinventing 😄 |
|
After pygfx/wgpu-py#478 it should be possible to greatly simplify this |
|
I made some updates to make it work with the latest wgpu. Ready from my end! |
|
This is really great, thanks! 🥳 . Will merge once wgpu v0.15.1 is on pypi and tests pass |
Closes #384
fpl.utils/guimodule where the GUI selection is handled and nothing else.wgpu.gui.autoexcept infpl.utils.gui.fpl.run()method now matches the GUI backend in use (this was not necessarily the case previously).ipywidgetsis imported is now conditional (only happens in Jupyter notebook / lab).Note on performance: The import time is about 0.2 s faster on desktop (because it does not import Jupyter stuff). In the notebook we can expect a similar improvement because glfw and qt are not imported by default (when available).