8000 test: migrated custom-parser.3.test.js from tap to node:test by Tony133 · Pull Request #5903 · fastify/fastify · GitHub
[go: up one dir, main page]
Skip to content

test: migrated custom-parser.3.test.js from tap to node:test #5903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 22, 2024
Merged

test: migrated custom-parser.3.test.js from tap to node:test #5903

merged 5 commits into from
Dec 22, 2024

Conversation

Tony133
Copy link
Contributor
@Tony133 Tony133 commented Dec 16, 2024

Checklist

Proposal:

  • migrated custom-parser.3.test.js from tap to node:test 🔥

dancastillo
dancastillo reviewed Dec 17, 2024
View reviewed changes
@Eomm Eomm added the test Issue or pr related to our testing infrastructure. label Dec 17, 2024
gurgunday
gurgunday reviewed Dec 17, 2024
View reviewed changes
Copy link
Member
@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address @dancastillo's feedback

dancastillo
dancastillo reviewed Dec 18, 2024
View reviewed changes
Eomm
Eomm reviewed Dec 19, 2024
View reviewed changes
gurgunday
gurgunday approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member
@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit a835325 into fastify:main Dec 22, 2024
25 checks passed
@renovate renovate bot mentioned this pull request Jan 9, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancastillo dancastillo dancastillo left review comments

@Eomm Eomm Eomm approved these changes

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
test Issue or pr related to our testing infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tony133 @Eomm @dancastillo @gurgunday
0