8000 feat: Inject http error detail into user authentication dependency injector for every case by caniko · Pull Request #1407 · fastapi-users/fastapi-users · GitHub
[go: up one dir, main page]
Skip to content

feat: Inject http error detail into user authentication dependency injector for every case #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Inject http error detail into user authentication dependency injector for every case #1407

wants to merge 1 commit into from

Conversation

caniko
Copy link
Contributor
@caniko caniko commented Jul 7, 2024 •
edited
Loading

Define the previously absent HTTP error details in user dependency injections that don't meet developer-defined requirements (active, verified, ...). I rewrote the 2nd half of Authenticator._authenticate, and believe the new version to be clearer.

The existing testing suite should be sufficient.

@caniko caniko force-pushed the feat/minor-authenticate-http-exception-detail-inject branch from 0021b23 to 3571e53 Compare July 7, 2024 14:51
@codecov Codecov
Copy link
codecov bot commented Jul 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6ac64ad) to head (3571e53).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #1407   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines          970       977    +7     
=========================================
+ Hits           970       977    +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caniko
0