10000 ✨ Implement list parsing from string with separators. by libklein · Pull Request #800 · fastapi/typer · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Implement list parsing from string with separators. #800

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

✨ Implement list parsing from string with separators. #800

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a6a797d
Implement list parsing from string with separators.
libklein Apr 17, 2024
7eb3fd2
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] Apr 17, 2024
cec52c9
Do not allow multi-character separators for List[T] parsing.
libklein Apr 17, 2024
f1ca3bd
Move multiple separator error checking to option construction.
libklein Apr 18, 2024
aca33a5
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] Apr 18, 2024
46b4690
Fix linter errors.
libklein Apr 18, 2024
7c78c51
Ignore mutable data structures error for added tutorial file.
libklein Apr 18, 2024
c0aba28
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] Apr 18, 2024
6233289
Use typing.List instead of list in test_others.
libklein Apr 18, 2024
f09da73
Do not collect coverage on unused command in test_others.
libklein Apr 18, 2024
3cdd682
Add documentation.
libklein Apr 18, 2024
03558cb
Rename `multiple_separator` to `separator`.
libklein Apr 25, 2024
e54193b
Fix missing word in documentation
libklein Apr 26, 2024
e4781dd
update documentation
svlandeg Jul 24, 2024
1793f0f
Extend error message to point to valid separators
svlandeg Jul 24, 2024
ae11002
Update error msg in test
svlandeg Jul 24, 2024
de078a6
Merge branch 'master' into multiple-arguments-via-separated-lists
svlandeg Aug 9, 2024
d5328fa
Update tests to clarify that whitespace between options is unsupported.
libklein Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not allow multi-character separators for List[T] parsing.
  • Loading branch information
@libklein
libklein committed Apr 17, 2024
commit cec52c953e60c29e8fac466b9a604295a71fcb31
7 changes: 3 additions & 4 deletions typer/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,10 +461,9 @@ def __init__(
self.multiple_separator = multiple_separator

if self.multiple_separator is not None:
if self.multiple_separator.strip() == "":
raise UnsupportedMultipleSeparatorError(
self.name, self.multiple_separator
)
self.multiple_separator = self.multiple_separator.strip()
if len(self.multiple_separator) != 1:
raise UnsupportedMultipleSeparatorError(self.name, multiple_separator)

if not isinstance(self.type, list):
raise MultipleSeparatorForNonListTypeError(self.name)
Expand Down
Loading
0