8000 ♻ Refactor dict value extraction to minimize key lookups `fastapi/utils.py` by ShahriyarR · Pull Request #3139 · fastapi/fastapi · GitHub
[go: up one dir, main page]
Skip to content

♻ Refactor dict value extraction to minimize key lookups fastapi/utils.py #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiangolo merged 2 commits into from
May 12, 2022
Merged

♻ Refactor dict value extraction to minimize key lookups fastapi/utils.py #3139

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32df705
unpack the value using .items() to eliminate 3 extra key lookup
ShahriyarR Apr 29, 2021
6662091
Merge branch 'master' into unpack-value-from-update-dict
tiangolo May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
unpack the value using .items() to eliminate 3 extra key lookup
  • Loading branch information
@ShahriyarR
ShahriyarR committed Apr 29, 2021
commit 32df705c70d2835e74c2da9ea4471a8b176517f0
8 changes: 4 additions & 4 deletions fastapi/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,15 @@ def generate_operation_id_for_path(*, name: str, path: str, method: str) -> str:


def deep_dict_update(main_dict: Dict[Any, Any], update_dict: Dict[Any, Any]) -> None:
for key in update_dict:
for key, value in update_dict.items():
if (
key in main_dict
and isinstance(main_dict[key], dict)
and isinstance(update_dict[key], dict)
and isinstance(value, dict)
):
deep_dict_update(main_dict[key], update_dict[key])
deep_dict_update(main_dict[key], value)
else:
main_dict[key] = update_dict[key]
main_dict[key] = value


def get_value_or_default(
Expand Down
0