10000 🐛 Check Content-Type request header before assuming JSON by patrickkwang · Pull Request #2118 · fastapi/fastapi · GitHub
[go: up one dir, main page]
Skip to content

🐛 Check Content-Type request header before assuming JSON #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiangolo merged 12 commits into from
Jun 7, 2021
+92 −12
Merged

🐛 Check Content-Type request header before assuming JSON #2118

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e46bce3
Check Content-Type before assuming JSON
Oct 2, 2020
df4fdf0
Remove now-unneccessary exception handling
Oct 2, 2020
4e8605e
Fix broken-body test
Oct 2, 2020
c7191f5
Assume "Content-Type": "application/octet-stream"
Oct 2, 2020
c169258
Explicitly specify Content-Type in gzip test
Oct 2, 2020
d644c30
Interpret as JSON any mimetype ending with "json"
Oct 2, 2020
6ecfba9
Generalize media type parsing to handle parameters
Oct 3, 2020
d752efd
Add test for handling va 8000 rious Content-Type headers
patrickkwang Jan 20, 2021
f80305d
✅ Update tests for content-type headers and include extra corner case
tiangolo Jun 7, 2021
344ae3f
♻️ Re-implement JSON content-type parsing with Python's standard libr…
tiangolo Jun 7, 2021
29257d0
🔀 Merge master to update codebase, dependencies and tests
tiangolo Jun 7, 2021
5729e8a
✅ Include again test with patch to force exception, for coverage
tiangolo Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix broken-body test
  • Loading branch information
@patrickkwang
Patrick Wang authored and patrickkwang committed Apr 10, 2021
commit 4e8605e5bf2c32082c7292be92838532d734d29b
13 changes: 3 additions & 10 deletions tests/test_tutorial/test_body/test_tutorial001.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,16 +178,9 @@ def test_post_broken_body():
assert response.json() == {
"detail": [
{
"ctx": {
"colno": 1,
"doc": "name=Foo&price=50.5",
"lineno": 1,
"msg": "Expecting value",
"pos": 0,
},
"loc": ["body", 0],
"msg": "Expecting value: line 1 column 1 (char 0)",
"type": "value_error.jsondecode",
"loc": ["body"],
"msg": "value is not a valid dict",
Copy link
Contributor
@ArcLightSlavik ArcLightSlavik Oct 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be considered a breaking change. Think even my work API has a test similar to this.

"type": "type_error.dict",
}
]
}
Expand Down
0