8000 ➖ Do not require backports in Python >= 3.7 by FFY00 · Pull Request #1880 · fastapi/fastapi · GitHub
[go: up one dir, main page]
Skip to content

➖ Do not require backports in Python >= 3.7 #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiangolo merged 2 commits into from
Oct 5, 2021
Merged

➖ Do not require backports in Python >= 3.7 #1880

tiangolo merged 2 commits into from
Oct 5, 2021

Conversation

@FFY00
Copy link
Contributor
@FFY00 FFY00 commented Aug 12, 2020

Signed-off-by: Filipe Laíns lains@archlinux.org

@FFY00
pyproject: skip Python 3.7 backport requirements on Python >= 3.7
8cbba98 
Signed-off-by: Filipe Laíns <lains@archlinux.org>
@codecov
Copy link
codecov bot commented Aug 12, 2020 •
edited
Loading

Codecov Report

Merging #1880 (0793a53) into master (5607c19) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1880   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          410       410           
  Lines        10281     10281           
=========================================
  Hits         10281     10281

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5607c19...0793a53. Read the comment docs.

@FFY00
Copy link
Contributor Author
FFY00 commented Aug 12, 2020

This should avoid some extra package installation for some users, as well as act as a reminder to remove the dependency and code when you move to Python 3.7 as the minimum version 😊

@github-actions
Copy link
Contributor
github-actions bot commented Aug 12, 2020

📝 Docs preview for commit 8cbba98 at: https://5f33ea6535aa1947e18c28e6--fastapi.netlify.app

@github-actions
Copy link
Contributor
github-actions bot commented Oct 5, 2021

📝 Docs preview for commit 0793a53 at: https://615c130f97b64ad8481adb06--fastapi.netlify.app

@tiangolo tiangolo changed the title pyproject: skip Python 3.7 backport requirements on Python >= 3.7 ➖ Do not require backports in Python >= 3.7 Oct 5, 2021
@tiangolo
Copy link
Member
tiangolo commented Oct 5, 2021 •
edited
Loading

Awesome, thanks @FFY00! 🚀

This is included in FastAPI 0.68.3, just released. 🎉

@tiangolo tiangolo merged commit 8a02a47 into fastapi:master Oct 5, 2021
@kritsada1998mtcn-ctrl kritsada1998mtcn-ctrl mentioned this pull request Nov 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aviramha aviramha aviramha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FFY00 @tiangolo @aviramha
0