8000 🐛 Fix `separate_input_output_schemas=False` with `computed_field` by YuriiMotov · Pull Request #14453 · fastapi/fastapi · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@YuriiMotov
Copy link
Member
@YuriiMotov YuriiMotov commented Dec 4, 2025

This fixes the issue reported in #14451.

The problem was that we calculated override_mode once for all models and if any of them had computed_field we set override_mode=None for all of the instead of doing it for this one only.

@YuriiMotov YuriiMotov added the bug Something isn't working label Dec 4, 2025
@YuriiMotov YuriiMotov force-pushed the fix-separate_input_output_schemas-with-computed_field branch from d40ef38 to fcc9065 Compare December 4, 2025 09:59
@YuriiMotov YuriiMotov marked this pull request as ready for review December 4, 2025 13:06
Copy link
@coltonevansid coltonevansid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix! 🎉

Copy link
Member
@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job @YuriiMotov! 🙌 🚀

This will be available in FastAPI 0.123.10 released in the next hours. 🎉

@tiangolo tiangolo merged commit 812a192 into fastapi:master Dec 5, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0