8000 📝 Fix test badge by esadek · Pull Request #13313 · fastapi/fastapi · GitHub
[go: up one dir, main page]
Skip to content

📝 Fix test badge #13313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
svlandeg merged 4 commits into from
Feb 10, 2025
Merged

📝 Fix test badge #13313

svlandeg merged 4 commits into from
Feb 10, 2025

Conversation

@esadek
Copy link
Contributor
@esadek esadek commented Feb 3, 2025

Before:
image

After:
image

@alejsdev alejsdev added the bug Something isn't working label Feb 3, 2025
@alejsdev
Copy link
Member
alejsdev commented Feb 3, 2025

Hello @esadek

Thanks for your interest in contributing to FastAPI. However, this change has to be done in /home/user/code/fastapi/docs/en/docs/index.md as well. Could you update this PR? Thanks 😄

@alejsdev alejsdev added waiting internal and removed bug Something isn't working labels Feb 3, 2025
@alejsdev alejsdev changed the title Fix test badge 📝 Fix test badge Feb 3, 2025
@github-actions github-actions bot added the docs Documentation about how to use FastAPI label Feb 3, 2025
@esadek
Copy link
Contributor Author
esadek commented Feb 3, 2025

@alejsdev Updated the docs as well

@github-actions github-actions bot removed the waiting label Feb 3, 2025
@alejsdev alejsdev removed the internal label Feb 4, 2025
@github-actions
Copy link
Contributor
github-actions bot commented Feb 7, 2025

📝 Docs preview for commit 41cf9d0 at: https://d3fa38e6.fastapitiangolo.pages.dev

Modified Pages

@alv2017 alv2017 mentioned this pull request Feb 9, 2025
Merged
svlandeg
svlandeg approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member
@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @esadek! I wonder whether the format of this has changed recently, because it definitely was working before 🤔

Either way, the format you're using is the one currently documented so looks good. Thanks again!

I will merge this and follow up with a separate PR #13329 to make sure this gets fixed in all other languages as well.

@svlandeg svlandeg merged commit 126a9b3 into fastapi:master Feb 10, 2025
52 checks passed
@svlandeg svlandeg mentioned this pull request Nov 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees

No one assigned

Labels

docs Documentation about how to use FastAPI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@esadek @alejsdev @svlandeg
0