8000 🌐 Add Indonesian translation for `docs/id/docs/tutorial/first-steps.md` by gerry-sabar · Pull Request #13042 · fastapi/fastapi · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@gerry-sabar
Copy link
Contributor

Hi, I notice the Indonesian translation for this section isn't maintained. Going forward I'd love to bring more contribution for Indonesian translation starting from this file @tiangolo

@github-actions github-actions bot added the lang-all Translations label Dec 6, 2024
@github-actions
Copy link
Contributor
github-actions bot commented Dec 6, 2024

@alejsdev alejsdev changed the title add indonesian translation for docs/id/docs/tutorial/first-steps.md 🌐 Add Indonesian translation for docs/id/docs/tutorial/first-steps.md Dec 9, 2024
@alejsdev alejsdev added awaiting-review lang-id Indonesian translations labels Dec 9, 2024
Copy link
@RyaWcksn RyaWcksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
@ilhamfadillah ilhamfadillah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Good

Copy link
@ilhamfadillah ilhamfadillah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its ok


{* ../../docs_src/first_steps/tutorial003.py hl[7] *}

/// catatan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not displaying properly. Can you check it, please?
You can check the translation guidelines if you have any questions. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alejsdev thanks for the review. I have fixed improper code for text boxes so now all text boxes are displayed properly

@gerry-sabar gerry-sabar force-pushed the docs/id/docs/tutorial/first-steps.md branch from 9f9a793 to b4f8da2 Compare December 12, 2024 16:58
@github-actions
Copy link
Contributor

@alejsdev alejsdev removed the waiting label Dec 12, 2024
@github-actions
Copy link
Contributor

@alejsdev alejsdev merged commit 974284b into fastapi:master Dec 12, 2024
50 checks passed
@alejsdev
Copy link
Member

Thank you for the help! @gerry-sabar 🚀

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7601

Labels

approved-2 lang-all Translations lang-id Indonesian translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0