8000 ✏️ Fix error in `docs/en/docs/contributing.md` by kingsubin · Pull Request #12899 · fastapi/fastapi · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@kingsubin
Copy link
Contributor
@kingsubin kingsubin commented Nov 11, 2024

Fix the --dev-addr option format to use required HOST:PORT syntax

  • Before: mkdocs serve --dev-addr 8008
  • After: mkdocs serve --dev-addr localhost:8008

@kingsubin kingsubin changed the title 📝 Fix incorrect mkdocs serve command in contributing guide 📝 Fix incorrect mkdocs serve command in contributing.md Nov 11, 2024
@github-actions github-actions bot added the docs Documentation about how to use FastAPI label Nov 11, 2024
@github-actions
Copy link
Contributor

@kingsubin kingsubin changed the title 📝 Fix incorrect mkdocs serve command in contributing.md ✏️ Fix error in docs/en/docs/contributing.md Nov 11, 2024
Copy link
Contributor
@alv2017 alv2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR proposed by @kingsubin fixes the error in the documentation.

@github-actions
Copy link
Contributor

@alejsdev alejsdev merged commit abac475 into fastapi:master Dec 25, 2024
50 checks passed
@alejsdev
Copy link
Member

Good catch, thank you! @kingsubin 🚀

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation about how to use FastAPI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0