8000 🌐 Add Portuguese translation for `docs/pt/docs/advanced/middleware.md` by devluisrodrigues · Pull Request #12704 · fastapi/fastapi · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@devluisrodrigues
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the lang-all Translations label Oct 28, 2024
@github-actions
Copy link
Contributor

@alejsdev alejsdev changed the title 🌐 Add Portuguese translation for docs/pt/docs/advanced/middleware.md 🌐 Add P 8000 ortuguese translation for docs/pt/docs/advanced/middleware.md Oct 28, 2024
@alejsdev alejsdev added awaiting-review lang-pt Portuguese translations labels Oct 28, 2024
Copy link
Contributor
@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, keep going with this kind of contribution.

@nazarepiedady
Copy link
Contributor

@ceb10n and @cassiobotaro, could one of you do the kindness of reviewing this pull request?

Copy link
Contributor
@ceb10n ceb10n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @devluisrodrigues

Just a line that you've forgotten to remove, and a quote in the admonition


**FastAPI** inclui vários middlewares para casos de uso comuns, veremos a seguir como usá-los.

/// note | "Detalhes Técnicos"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the quotes here:

/// note | Detalhes Técnicos

* <a href="https://github.com/encode/uvicorn/blob/master/uvicorn/middleware/proxy_headers.py" class="external-link" target="_blank">Uvicorn's `ProxyHeadersMiddleware`</a>
* <a href="https://github.com/florimondmanca/msgpack-asgi" class="external-link" target="_blank">MessagePack</a>

To see other available middlewares check <a href="https://www.starlette.io/middleware/" class="external-link" target="_blank">Starlette's Middleware docs</a> and the <a href="https://github.com/florimondmanca/awesome-asgi" class="external-link" target="_blank">ASGI Awesome List</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've forgotten to remove this line 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh haha, I'm sorry for that. I'll fix it!

@devluisrodrigues
Copy link
Contributor Author

Hey @ceb10n and @nazarepiedady thank you for your feedback! I'll adress the changes and make a PR

@github-actions
Copy link
Contributor

@devluisrodrigues
Copy link
Contributor Author

I just committed the changes. @ceb10n if you need anything else, feel free to ask!

Copy link
Contributor
@ceb10n ceb10n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alejsdev alejsdev enabled auto-merge (squash) October 30, 2024 19:57
@alejsdev
Copy link
Member

Great, thanks! @devluisrodrigues 🎉

@alejsdev alejsdev merged commit 3184b5c into fastapi:master Oct 30, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-pt Portuguese translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0