8000 🌐 Add Dutch translation for `docs/nl/docs/index.md` by svlandeg · Pull Request #12042 · fastapi/fastapi · GitHub 8000
[go: up one dir, main page]

Skip to content

Conversation

@svlandeg
Copy link
Member

This PR builds upon the previous efforts by @maxscheijen and his original PR #5366.

I applied the reviewer comments and updated the page with the latest changes from master.

As a native Dutch speaker myself, I went through the text and added a few more fixes as well.

@github-actions github-actions bot added the lang-all Translations label Aug 19, 2024
@svlandeg svlandeg added awaiting-review lang-nl Dutch translations labels Aug 19, 2024
@github-actions
Copy link
Contributor

📝 Docs preview for commit 4774217 at: https://b4009269.fastapitiangolo.pages.dev

Modified Pages

Copy link
@d2a-raudenaerde d2a-raudenaerde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sofie, thanks for the translation effort!

As a native Dutch speaker and developer, I always feel a bit awkward reading Dutch programming-documentation, so my main feedback would be that it would be a bit of a waste of time as you need a proper understanding of English anyway if you want to develop effectively. Also; adding a translation increases the workload of keeping all translations in sync if the main source is changed. I am inclined to the less-is-more.

However it might be worth the effort to some ppl!

My main feedback is that 'high performance' does not have a proper Dutch translation. "hoogwaardige prestatie" might be the most accurate translation, "(zeer) goede prestaties" somewhat feels better.

(ps I see you are from Belgium so probably used to Flemish? that might explain some sentences that feel a bit off in Dutch from the Netherlands)

@svlandeg
Copy link
Member Author
svlandeg commented Aug 27, 2024

Thanks for the review @d2a-raudenaerde!

As a native Dutch speaker and developer, I always feel a bit awkward reading Dutch programming-documentation

Totally agree! I find these super awkward myself. Still, FastAPI has been offering translations in various languages for some time now, and I do think it may help lower the barrier for non-native English speaking people. I wanted Dutch to be at least represented 😉

My main feedback is that 'high performance' does not have a proper Dutch translation. "hoogwaardige prestatie" might be the most accurate translation, "(zeer) goede prestaties" somewhat feels better.

I used this suggestion to make some edits ^^

(ps I see you are from Belgium so probably used to Flemish? that might explain some sentences that feel a bit off in Dutch from the Netherlands)

Yep I'm indeed Flemish. Feel free to mark specific sentences you feel are "off" and/or suggest alternatives. I have the same when I read translations from people from the Netherlands though, there's always going to be a slight difference in language usage 🙈

@github-actions
Copy link
Contributor

📝 Docs preview for commit 304aaa9 at: https://e57ad853.fastapitiangolo.pages.dev

Modified Pages

Copy link
@d2a-raudenaerde d2a-raudenaerde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paar kleine punten

@github-actions
Copy link
Contributor

📝 Docs preview for commit d4afbc0 at: https://68633c7f.fastapitiangolo.pages.dev

Modified Pages

@github-actions
Copy link
Contributor

📝 Docs preview for commit 9f6f4c2 at: https://f0b58d69.fastapitiangolo.pages.dev

Modified Pages

Copy link
@d2a-raudenaerde d2a-raudenaerde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lijkt me mooi zo! - Looks good to me ;)

6D40

@tiangolo
Copy link
Member

Awesome, thank you @svlandeg! 🚀

And thanks @d2a-raudenaerde for the reviews and help! 🍰

@tiangolo tiangolo merged commit ae27540 into fastapi:master Aug 28, 2024
@svlandeg svlandeg deleted the feat/dutch-1 branch August 29, 2024 12:36
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
Co-authored-by: Max Scheijen <maxscheijen@gmail.com>
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
Co-authored-by: Max Scheijen <maxscheijen@gmail.com>
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
Co-authored-by: Max Scheijen <maxscheijen@gmail.com>
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Co-authored-by: Max Scheijen <maxscheijen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-1 lang-all Translations lang-nl Dutch translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0