8000 Fix FillMissing processor by removing inplace=True by nikhilmalkari8 · Pull Request #4055 · fastai/fastai · GitHub
[go: up one dir, main page]
Skip to content

Fix FillMissing processor by removing inplace=True #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix FillMissing processor by removing inplace=True #4055

wants to merge 1 commit into from

Conversation

@nikhilmalkari8
Copy link
@nikhilmalkari8 nikhilmalkari8 commented Nov 27, 2024

Issue:

  • The FillMissing processor in tabular.core raised a warning due to the deprecated inplace=True in Pandas.
  • This caused compatibility issues with recent Pandas versions.

Fix:

  • Replaced inplace=True with reassignment in the FillMissing processor.
  • Updated FillMissing to work with TabularPandas objects and tested the behavior.

Test:

  • Added a new test in tests/test_tabular_core.py to validate the FillMissing functionality.
  • Verified that missing values are filled correctly in continuous columns.

@jph00
Copy link
Member
jph00 commented Nov 27, 2024

I do not see any mention in the pandas docs of a deprecation?

NB: this is an nbdev project, so the source files are the notebooks, and that's where tests go too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jph00 jph00 Awaiting requested review from jph00 jph00 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikhilmalkari8 @jph00
0