8000 Replace TL;DR80 -> TL;DR by s3bw · Pull Request #297 · faif/python-patterns · GitHub
[go: up one dir, main page]

Skip to content

Replace TL;DR80 -> TL;DR #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2019
Merged

Replace TL;DR80 -> TL;DR #297

merged 1 commit into from
May 10, 2019

Conversation

s3bw
Copy link
Contributor
@s3bw s3bw commented May 10, 2019

I actually appreciate having the line length not going over 80 since I am an avid vim user, work of a laptop, and usually need 3 windows open at once.

I am removing this because I think it's meaning is ambiguous and even if it did indicate line-length, this rule isn't strictly adhered to.

Thanks @faif

Closes: #228

@codecov-io
Copy link

Codecov Report

Merging #297 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   32.82%   32.82%           
=======================================
  Files          42       42           
  Lines        1496     1496           
=======================================
  Hits          491      491           
  Misses       1005     1005
Impacted Files Coverage Δ
patterns/structural/flyweight__py2.py 0% <ø> (ø) ⬆️
patterns/structural/mvc.py 0% <ø> (ø) ⬆️
patterns/creational/factory.py 0% <ø> (ø) ⬆️
patterns/behavioral/iterator.py 0% <ø> (ø) ⬆️
patterns/behavioral/strategy.py 0% <ø> (ø) ⬆️
patterns/behavioral/state.py 97.72% <ø> (ø) ⬆️
patterns/creational/prototype.py 60.71% <ø> (ø) ⬆️
patterns/structural/flyweight__py3.py 0% <ø> (ø) ⬆️
patterns/behavioral/mediator.py 0% <ø> (ø) ⬆️
...atterns/behavioral/chain_of_responsibility__py2.py 0% <ø> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1417906...2ea6bab. Read the comment docs.

@faif faif merged commit 8c47dfc into faif:master May 10, 2019
@s3bw s3bw deleted the 228-remove-80 branch May 10, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why are TL;DR suffixed with 80?
3 participants
0