Speedup patch embedding by moving coord creation on device #595
Conversation
|
Hi @Tom-Julux! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
While experimenting with image segmentation and using the
prunfunction onpredictor.set_image, I discovered a significant performance issue in theget_rel_posfunction.The problem arises from the lack of device assignment for the tensor containing relative positions, causing unnecessary data transfers when using accelerators like GPUs.
The solution is rather simple: create the coordinate tensor on the same device as the underlying data.
In my specific case (vit-b, P100 GPU, 128x128 image size), this change reduced the
get_rel_posexecution time from 197ms to 3ms, cutting down thepredictor.set_imageruntime from 220ms to 20ms.Given that there's no reason to keep the coordinate tensor creation outside the device, I suggest incorporating this change into the official release for the benefit of all users.