[feat] allow extra commandline args in sweep scripts #1057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8afbf1e to
5186890
Compare
Add `--extra_mmf_args` in sweep lib to allow passing additional MMF command-line arguments, like `mmf_run` and `mmf_predict`. Usage: append to the sweep script extra command line arguments such as `--extra_mmf_args training.checkpoint_interval 10000 training.batch_size 128` Test plan: tested on FAIR cluster
5186890 to
cd34129
Compare
|
@ronghanghu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
apsdehal
approved these changes
Aug 26, 2021
|
@ronghanghu has updated the pull request. You must reimport the pull request before landing. |
|
@ronghanghu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ronghanghu has updated the pull request. You must reimport the pull request before landing. |
|
@ronghanghu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
Summary: This PR adds `--extra_args` in sweep lib to allow passing additional MMF command-line arguments, like `mmf_run` and `mmf_predict`. Usage: one can append to the sweep script extra command line arguments such as ``` python tools/sweeps/sweep_visual_bert.py \ <gpu, node, or other arguments> \ --extra_args training.checkpoint_interval 10000 training.batch_size 128 ``` Note that it also support the other format with equal sign `=` in args such as `--extra_args training.batch_size=128` Pull Request resolved: #1057 Test Plan: tested on FAIR cluster Reviewed By: apsdehal Differential Revision: D30568684 Pulled By: ronghanghu fbshipit-source-id: 88f85be01b4aa3aa32d616ae72e4b84ce4e51aa5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--extra_argsin sweep lib to allow passing additional MMFcommand-line arguments, like
mmf_runandmmf_predict.Usage: one can append to the sweep script extra command line arguments such as
Note that it also support the other format with equal sign
=in args such as--extra_args training.batch_size=128Test plan: tested on FAIR cluster