This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Switch to the more conservative Immutable.js ~3.7.4 version to avoid upstream flow definition errors. #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upstream flow definition errors.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Closed
|
I'll see if I can get immutable-js/immutable-js#881 merged. |
|
I'm going to go ahead and merge this to get things unblocked. I'd really like to switch it back soon. |
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ouchxp
pushed a commit
to ouchxp/draft-js
that referenced
this pull request
Apr 7, 2017
…upstream flow definition errors. Summary: The `3.8.x` versions of Immutable.js have changed `#toOrderedMap(): OrderedMap` to `#toOrderedMap(): Map` which breaks Draf 8000 t.js — so I propose we use `~3.7.4` instead of `^3.7.4`. Draft.js's definition of `BlockMap` is `OrderedMap<string, ContentBlock>` which is not compatible with `Map`. In the interim (until Immutable.js makes a decision as to whether `#toOrderedMap(): Map` is correct) using the `3.7.x` range allows Draft.js `master` to pass flow checks. Closes facebookarchive#468 Differential Revision: D3456991 fbshipit-source-id: 0e9a176d800d3216d30b00ae1da1a682ee93273b
midas19910709
added a commit
to midas19910709/draft-js
that referenced
this pull request
Mar 30, 2022
…upstream flow definition errors. Summary: The `3.8.x` versions of Immutable.js have changed `#toOrderedMap(): OrderedMap` to `#toOrderedMap(): Map` which breaks Draft.js — so I propose we use `~3.7.4` instead of `^3.7.4`. Draft.js's definition of `BlockMap` is `OrderedMap<string, ContentBlock>` which is not compatible with `Map`. In the interim (until Immutable.js makes a decision as to whether `#toOrderedMap(): Map` is correct) using the `3.7.x` range allows Draft.js `master` to pass flow checks. Closes facebookarchive/draft-js#468 Differential Revision: D3456991 fbshipit-source-id: 0e9a176d800d3216d30b00ae1da1a682ee93273b
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
…upstream flow definition errors. Summary: The `3.8.x` versions of Immutable.js have changed `#toOrderedMap(): OrderedMap` to `#toOrderedMap(): Map` which breaks Draft.js — so I propose we use `~3.7.4` instead of `^3.7.4`. Draft.js's definition of `BlockMap` is `OrderedMap<string, ContentBlock>` which is not compatible with `Map`. In the interim (until Immutable.js makes a decision as to whether `#toOrderedMap(): Map` is correct) using the `3.7.x` range allows Draft.js `master` to pass flow checks. Closes facebookarchive/draft-js#468 Differential Revision: D3456991 fbshipit-source-id: 0e9a176d800d3216d30b00ae1da1a682ee93273b
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
…upstream flow definition errors. Summary: The `3.8.x` versions of Immutable.js have changed `#toOrderedMap(): OrderedMap` to `#toOrderedMap(): Map` which breaks Draft.js — so I propose we use `~3.7.4` instead of `^3.7.4`. Draft.js's definition of `BlockMap` is `OrderedMap<string, ContentBlock>` which is not compatible with `Map`. In the interim (until Immutable.js makes a decision as to whether `#toOrderedMap(): Map` is correct) using the `3.7.x` range allows Draft.js `master` to pass flow checks. Closes facebookarchive/draft-js#468 Differential Revision: D3456991 fbshipit-source-id: 0e9a176d800d3216d30b00ae1da1a682ee93273b
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
3.8.xversions of Immutable.js have changed#toOrderedMap(): OrderedMapto#toOrderedMap(): Mapwhich breaks Draft.js — so I propose we use~3.7.4instead of^3.7.4.Draft.js's definition of
BlockMapisOrderedMap<string, ContentBlock>which is not compatible withMap.In the interim (until Immutable.js makes a decision as to whether
#toOrderedMap(): Mapis correct) using the3.7.xrange allows Draft.jsmasterto pass flow checks.