feat: add support for optional parent with mandatory nested propertie… #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed optional parent field validation in schema validation
When using
checkSchema(), nested properties were being validated even when their optional parent field was missing from the request. This fix ensures that nested properties are only validated when their parent field is actually present.Changes Made
src/chain/context-runner-impl.tsto track which fields are marked as optionalProblem Solved
Before:
{ a: {} }would fail validation even thoughawas marked as optionalAfter:
{ a: {} }correctly fails only whenaexists, ensuring nested mandatory properties are validated appropriatelyTest Results