E543 Fix/with-apollo branch updates broken SWAPI endpoint, null checks, query schemas, updates to expo 54 and apollo 4. by AnupamKhosla · Pull Request #613 · expo/examples · GitHub
[go: up one dir, main page]
Skip to content

Fix/with-apollo branch updates broken SWAPI endpoint, null checks, query schemas, updates to expo 54 and apollo 4. #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix/with-apollo branch updates broken SWAPI endpoint, null checks, query schemas, updates to expo 54 and apollo 4. #613

wants to merge 1 commit into from
+110 −62

Conversation

AnupamKhosla
Copy link

I discovered some issued here #610.

  1. Original SWAPI endpoint was redirecting and losing POST query.
  2. Even the redirected endpoint did not have proper data such as manufactures etc.
  3. I created my own graphql wrapper around the REST based swapi.dev mirror https://swapi.py4e.com/api and updated with-apollo endpoint to mine.
  4. My wrapper API can be checked at https://github.com/AnupamKhosla/swapi-gql-wrapper.
  5. Apollo 3 is EOL outdated, so I changed that to the latest Apollo4, which requires @apollo/client/react in import.
  6. I changed gql queries slightly to match my wrapper api.
  7. I added some option chaining for null checks data?.starshipById.
  8. Update to Expo 54.

@AnupamKhosla AnupamKhosla changed the title Fix/with apollo branch updates broken SWAPI endpoint, null checks, query schemas, updates to expo 54 and apollo 4. Fix/with-apollo branch updates broken SWAPI endpoint, null checks, query schemas, updates to expo 54 and apollo 4. Sep 11, 2025
@AnupamKhosla
Copy link
Author

I had some merges with the old master branch, that remained in the commit history. I rebased my whole fix/with-apollo branch with the latest master branch. Now my branch is just one commit ahead of latest master. It has only the ./with-apollo folder, which is different from the master branch. fix/with-apollo can be merged into master straight away, it will only override ./with-apollo folder with no conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AnupamKhosla
0