Add placeholder and params for all_your_base, add params for collatz_conjecture#577
Closed
smt923 wants to merge 0 commit intoexercism:masterfrom
Closed
Add placeholder and params for all_your_base, add params for collatz_conjecture#577smt923 wants to merge 0 commit intoexercism:masterfrom
smt923 wants to merge 0 commit intoexercism:masterfrom
Conversation
Contributor
|
Thanks for your work but could you please separate your changes into one PR per exercise. Background: #631 (comment) |
<
8E18
div class="d-flex flex-row-reverse flex-items-center flex-shrink-0 pl-3">
Contributor
Author
|
Welp didn't mean to close this but frankly it's easier if I just make two new PRs anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should close #538 and #552, if you'd rather the collatz_conjecture param be "n" to match example.py I can change it real fast, but I assumed number was a little more descriptive/helpful