robot-simulator: Updated test order to match canonical-data.json#1043
Merged
N-Parsons merged 5 commits intoexercism:masterfrom Oct 27, 2017
Merged
robot-simulator: Updated test order to match canonical-data.json#1043N-Parsons merged 5 commits intoexercism:masterfrom
N-Parsons merged 5 commits intoexercism:masterfrom
Conversation
cmccandless
approved these changes
Oct 26, 2017
N-Parsons
suggested changes
Oct 27, 2017
Contributor
There was a problem hiding this comment.
Looks good, but please see comment re: version string position. Once this resolved, I will merge it.
| from robot_simulator import Robot, NORTH, EAST, SOUTH, WEST | ||
|
|
||
| # Tests adapted from `problem-specifications//canonical-data.json` @ v2.0.0 | ||
|
|
Contributor
There was a problem hiding this comment.
For consistency, can you move the version string down by a line? (ie. so that there are two blank lines before and one after the comment).
N-Parsons
approved these changes
Oct 27, 2017
Contributor
|
Thanks, @denislooby! |
josix
pushed a commit
to josix/python
that referenced
this pull request
Oct 28, 2017
…rcism#1043) * robot-simulator: Updated test order to match canonical-data.json
smalley
pushed a commit
to smalley/python
that referenced
this pull request
Nov 12, 2017
…rcism#1043) * robot-simulator: Updated test order to match canonical-data.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1004