Adds a bonus challenge to the Hello World#1008
Adds a bonus challenge to the Hello World#1008SSU04096 wants to merge 2 commits intoexercism:masterfrom
Conversation
|
Thank you for your contribution @SSU04096 :) However, I'm not sure if we want to add any extra challanges to the hello world exercise. That exercise is meant to be the first exercise on the track and should therefore be very simple. If people want an extra challenge after finishing the exercise then they can move on to the next exercise which should be more challenging. Especially since the challenge involves having the user enter something which would involve writing a new method which takes an argument, or changing the method signature of the first method to take an argument (which would involve changing all the other tests to reflect this). And tests to test this behaviour would need to be written. All in all this sounds like a lot of work for the first exercise on the track. Other maintainers might disagree with me though :) What do you think @exercism/java? |
|
No problem! I just wanted to get some experience with forking and making pull requests. Thank you for taking the time to review my request. |
|
Welcome! As @FridaTveit says, this is not a change we'll accept into the track at this time. If you are interested in further practicing your git workflow and contributing to open source, there are a number of pieces of work we've previously identified as (1) desirable and (2) suitable for newcomers! You can find them here: https://github.com/exercism/java/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+patch%22 If any of them interest you, comment on the issue to indicate you're working on it, and feel free to reach out with any questions as you go :) |
I am new to contributing to GitHub. I wanted to try forking/pull on GitHub. I added a challenge to the Hello World Exercise. Thank you!
Reviewer Resources:
Track Policies