8000 Drop unused 1bpp support from Stretch LCD code by JakubVanek · Pull Request #792 · ev3dev-lang-java/ev3dev-lang-java · GitHub
[go: up one dir, main page]
Skip to content

D 8000 rop unused 1bpp support from Stretch LCD code #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Drop unused 1bpp support from Stretch LCD code #792

wants to merge 2 commits into from

Conversation

JakubVanek
Copy link
Contributor < 8000 /div>

Related to #791

@jabrena
Copy link
Member
jabrena commented Jan 10, 2021 •
edited
Loading

Hi Jakub, can you remember what is:

  • Drop unused 1bpp support

I don’t remember it. We added 2 years ago +-

Did you test the branch with the brick?

Here, you have an example to test that everything goes well:
https://github.com/ev3dev-lang-java/template-project-gradle/blob/master/src/main/java/example/programming/FractalCircle.java

@JakubVanek
Copy link
Contributor Author

Did you test the branch with the brick?

No, I don't currently have a free SD card (currently it is used by a non-robotic RPi, although I can reflash it later).

I think I remember that Jessie used 1bpp packed black and white bitmaps and Stretch used 32bpp XRGB8888 bitmaps. However, because the Jessie codepath somehow didn't work, the old LCD implementation was copied over untouched and the new code is used only on Stretch (and Buster nowadays).

@jabrena
Copy link
Member
jabrena commented Jan 11, 2021

Hi Jakub, did you test it?

@JakubVanek
Copy link
Contributor Author

Not yet, and as such I have to close this PR.

@JakubVanek JakubVanek closed this Jan 11, 2021
@jabrena jabrena reopened this Jan 11, 2021
@jabrena
Copy link
Member
jabrena commented Jan 11, 2021 •
edited
Loading

When you test in local, I will merge it.
The idea is good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakubVanek @jabrena
0