Make the movie lister example work on Windows #458
Conversation
…l newline, which made the example fail on Windows. - Changed the relative imports to absolute imports so the example works out of the box in VS Code. - Added a shell script and a batch file to run the example on Linux and Windows.
There was a problem hiding this comment.
Hey @jpvandervelden :) Thanks a lot for the contribution and glad you've figured it out how to run it on windows. I posted a couple of actions. Appreciate if you could take a look.
| @@ -4,8 +4,8 @@ | |||
|
|
|||
| from dependency_injector.wiring import inject, Provide | |||
|
|
|||
| from .listers import MovieLister | |||
| from .containers import Container | |||
| from movies.listers import MovieLister | |||
There was a problem hiding this comment.
I looked for any specific behavior of relative imports on Windows, but didn't find anything. Seems like you've had a problem with it. Do you remember how you ran it and what was the problem?
There was a problem hiding this comment.
It was a problem when using VS Code..
examples/miniapps/movie-lister/setup_and_run_movie_lister.b
8000
at
Outdated
Show resolved
Hide resolved
|
|
||
| rm -rf wslenv2 | ||
|
|
||
| python3 -m venv wslenv2 |
There was a problem hiding this comment.
So, this is basically doing what is done in the readme, correct?
| @@ -72,3 +72,12 @@ src/dependency_injector/providers/*.so | |||
|
|
|||
| # Workspace for samples | |||
| .workspace/ | |||
| /examples/miniapps/movie-lister/wslenv2-win/Scripts | |||
There was a problem hiding this comment.
I'm unsure we need these imports here
There was a problem hiding this comment.
This is how the virtual environment is created under Windows.
Changed script to use multiline command separator for the long command sequence. Added some comment lines.
As a Java guy I'd like to use the dependency injection in Python too. I found this library. It didn't work for me at first on Windows & VS Code. I made some changes so now it works on Linux and Windows.
Keep up the good work!