This repository was archived by the owner on Dec 10, 2020. It is now read-only.
Add web3_* RPC endpoints #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpulim
reviewed
Nov 8, 2018
vpulim
reviewed
Nov 8, 2018
Contributor
|
Thanks for this contribution! Can you please merge commits into a single commit that includes the tests so we don't pollute the commit history (maybe keep the comment as "Add web3_* rpc endpoints")? Will merge once that's done. |
Contributor
Author
|
@vpulim If the PR is reviewed/approved, I believe Github gives me the option to squash the commits before I merge. |
Contributor
|
Ok, in that case feel free to merge |
Contributor
Author
|
@vpulim Ah, now Github's telling me that only those with write access can merge. Can you do it from your side? It should be available as a dropdown option on the merge button. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
web3_clientVersionandweb3_sha3RPC endpoints.