8000 Digitize high level diagram by ryanio · Pull Request #134 · ethereumjs/ethereumjs-client · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Dec 10, 2020. It is now read-only.

Conversation

@ryanio
Copy link
Contributor
@ryanio ryanio commented Jun 18, 2020

This PR digitizes the helpful diagram that @holgerd77 made.

To update in the future: open the client.drawio file in draw.io, make your changes, and open a PR with the updated files. Export svg and png with border width=20 and transparency=false. For png go to Advanced and select 300 DPI.

@coveralls
Copy link
coveralls commented Jun 18, 2020

Coverage Status

Coverage remained the same at 91.886% when pulling 000b8d9 on digitize-diagram into 9b32bd3 on master.

@holgerd77
Copy link
Member

Oh, yeah, svg makes a lot of sense here, I am not so on everyday-remembrance with graphics formats. 😄

Copy link
Member
@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Ryan!

@holgerd77 holgerd77 merged commit cd3e78a into master Jun 19, 2020
@holgerd77 holgerd77 deleted the digitize-diagram branch June 19, 2020 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0