This repository was archived by the owner on Dec 10, 2020. It is now read-only.
remove old fields consensus and finality
#120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
approved these changes
Jun 3, 2020
Member
There was a problem hiding this comment.
Looks good, good catch, didn't know this was consumed here
| params.hardforks = hardforks.map(name => ({ | ||
| name: name, | ||
| block: name === 'chainstart' ? 0 : json.config[forkMap[name]] || null, | ||
| consensus: json.config.clique ? 'poa' : 'pow', |
Member
There was a problem hiding this comment.
Was a bit unsure about the consensus part, since the PoA information is directly extracted from a geth configuration file, but the information is nowhere used within the client so I think it should be safe to remove. Can also be re-added later if necessary, eventually in another context then.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows ethereumjs/ethereumjs-monorepo#758 to remove unused fields
consensusandfinality.