8000 Update LSK addresses by shuse2 · Pull Request #1210 · ethereum-optimism/ethereum-optimism.github.io · GitHub
[go: up one dir, main page]
Skip to content

Update LSK addresses #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update LSK addresses #1210

wants to merge 2 commits into from

Conversation

shuse2
Copy link
Collaborator
@shuse2 shuse2 commented Sep 19, 2025 •
edited
Loading

Description

Tests

Deployed the same contract on Base https://basescan.org/address/0xac485391EB2d7D88253a7F1eF18C37f4242D1A24#code as in Lisk

Additional context

LSK address for unichain was added by #1073, but we don't recognise this address

@shuse2 shuse2 requested a review from a team as a code owner September 19, 2025 10:42
@wiz-inc-a178a98b5d Wiz Inc. (a178a98b5d)
Copy link
wiz-inc-a178a98b5d bot commented Sep 19, 2025 •
edited
Loading

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Total -

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

wiz-inc-a178a98b5d[bot]
wiz-inc-a178a98b5d bot reviewed Sep 19, 2025
View reviewed changes
@shuse2 shuse2 review requested due to automatic review settings September 19, 2025 10:42
@shuse2 shuse2 added the base PR require review from base team label Sep 19, 2025
@shuse2 shuse2 requested a review from fainashalts September 19, 2025 10:45
@shuse2
Copy link
Collaborator Author
shuse2 commented Sep 19, 2025 •
edited
Loading

@fainashalts
it's not passing validate-workflow, but it's passing locally.

I cannot see why it's failing, could someone check?

@fainashalts
Copy link
Contributor

Hi @shuse2! This is the output I see for the failing validation:

LSK on chain lisk token 0xac485391EB2d7D88253a7F1eF18C37f4242D1A24 could not fetch l2Bridge or l1Token.
This token most likely needs nobridge or a bridge override set.
error: LSK on chain lisk-sepolia token 0x8a21CF9Ba08Ae709D64Cb25AfAA951183EC9FF6D could not fetch l2Bridge or l1Token.
This token most likely needs nobridge or a bridge override set.
error: LSK on chain base token 0xac485391EB2d7D88253a7F1eF18C37f4242D1A24 could not fetch l2Bridge or l1Token.
This token most likely needs nobridge or a bridge override set.

@shuse2 shuse2 force-pushed the update_lsk_token_address branch from 42914bd to bcc4b1c Compare September 28, 2025 10:21
@shuse2
Copy link
Collaborator Author
shuse2 commented Sep 28, 2025 •
edited
Loading

@fainashalts thanks for checking, i thought that was not needed anymore, so i removed in the last commit. Now it should be fine.
Could you re-check / merge the PR if possible?

@shuse2 shuse2 assigned shuse2 and unassigned shuse2 Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wiz-inc-a178a98b5d wiz-inc-a178a98b5d[bot] wiz-inc-a178a98b5d[bot] left review comments

@trianglesphere trianglesphere Awaiting requested review from trianglesphere

@fainashalts fainashalts Awaiting requested review from fainashalts

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

base PR require review from base team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shuse2 @fainashalts
0