8000 WIP: feat: adding composite repo with eclipse platform by sigmaaa · Pull Request #1412 · espressif/idf-eclipse-plugin · GitHub
[go: up one dir, main page]
Skip to content

WIP: feat: adding composite repo with eclipse platform#1412

Open
sigmaaa wants to merge 1 commit intomasterfrom
feat_adding_composite_repo
Open

WIP: feat: adding composite repo with eclipse platform#1412
sigmaaa wants to merge 1 commit intomasterfrom
feat_adding_composite_repo

Conversation

@sigmaaa
Copy link
Collaborator
@sigmaaa sigmaaa commented Mar 11, 2026 •
edited by coderabbitai bot
Loading

Description

Please include a summary of the change and which issue is fixed.

Fixes # (IEP-XXX)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Chores
    • Updated continuous integration workflow to reflect changes in artifact management paths.
    • Enhanced Maven build configuration with improved repository packaging and metadata generation for optimized distribution handling.

@sigmaaa sigmaaa self-assigned this Mar 11, 2026
@coderabbitai
Copy link
coderabbitai bot commented Mar 11, 2026 •
edited
Loading
📝 Walkthrough

Walkthrough

The changes introduce a composite repository build structure for the Espressif IDF. A new Maven plugin creates a composite-repo directory with organized artifacts and metadata files, while the CI workflow is updated to upload from the new composite-repo path.

Changes

Cohort / File(s) Summary
CI Workflow Update
.github/workflows/ci.yml		 Updated macOS build artifact upload path from repository to composite-repo.
Maven Build Configuration
releng/com.espressif.idf.update/pom.xml		 Added build timestamp format property and maven-antrun-plugin execution to create composite repository structure, copy repository contents, and generate compositeContent.xml and compositeArtifacts.xml metadata files with embedded timestamps.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • alirana01
  • kolipakakondal
  • AndriiFilippov

Poem

🐰 A composite repo, oh what a delight!
Files bundled together with timestamps so bright,
Maven and Ant work in perfect harmony,
Building repositories with synchronized symphony! 📦✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: adding a composite repository structure with Eclipse platform support via pom.xml configuration and CI workflow updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat_adding_composite_repo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Mar 11, 2026
View reviewed changes
Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
releng/com.espressif.idf.update/pom.xml (2)

32-32: Consider parameterizing the Eclipse release version.

The Eclipse release URL 2025-12 is hardcoded. This will require manual updates for each new Eclipse release cycle. Consider extracting this to a property for easier maintenance.

♻️ Proposed refactor

Add a property in the <properties> section:

<eclipse.release.version>2025-12</eclipse.release.version>

Then update the Ant property:

-<property name="eclipse.site" value="https://download.eclipse.org/releases/2025-12/"/>
+<property name="eclipse.site" value="https://download.eclipse.org/releases/${eclipse.release.version}/"/>
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@releng/com.espressif.idf.update/pom.xml` at line 32, The hardcoded Eclipse
release in the Ant property declaration for "eclipse.site" should be
parameterized: add a new Maven property (e.g., "eclipse.release.version") in the
<properties> section and replace the literal "2025-12" used in the
"eclipse.site" property value with a reference to that new property so the
release can be bumped by changing the property only.

21-22: Pin the plugin version for reproducible builds.

The maven-antrun-plugin lacks an explicit version. Maven will resolve to whatever version is available, which can cause inconsistent builds across environments.

♻️ Proposed fix 
 			<plugin>
 				<artifactId>maven-antrun-plugin</artifactId>
+				<version>3.2.0</version>
 				<executions>
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@releng/com.espressif.idf.update/pom.xml` around lines 21 - 22, The pom
currently declares the maven-antrun-plugin by artifactId without a version; add
an explicit <version> element under the <plugin> for maven-antrun-plugin to pin
the plugin (e.g., set version to a stable release such as 3.1.0 or your
project's approved fixed version) so builds are reproducible; update the
<plugin> block that contains artifactId "maven-antrun-plugin" to include the
chosen <version> value.
🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@releng/com.espressif.idf.update/pom.xml`:
- Line 32: The hardcoded Eclipse release in the Ant property declaration for
"eclipse.site" should be parameterized: add a new Maven property (e.g.,
"eclipse.release.version") in the <properties> section and replace the literal
"2025-12" used in the "eclipse.s
8EF8
ite" property value with a reference to that new
property so the release can be bumped by changing the property only.
- Around line 21-22: The pom currently declares the maven-antrun-plugin by
artifactId without a version; add an explicit <version> element under the
<plugin> for maven-antrun-plugin to pin the plugin (e.g., set version to a
stable release such as 3.1.0 or your project's approved fixed version) so builds
are reproducible; update the <plugin> block that contains artifactId
"maven-antrun-plugin" to include the chosen <version> value.
ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a4b6caaa-394b-4238-b5ed-e6cbad7ffe59

📥 Commits

Reviewing files that changed from the base of the PR and between 2261868 and 9ada86d.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • releng/com.espressif.idf.update/pom.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

@sigmaaa sigmaaa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sigmaaa
0