Implement new idf-v5 I2C driver #677
Conversation
|
Hi @playduck ! Thanks for the submission. I have one request, please have the new driver as new |
|
I agree; I didn't think about breaking the older versions. |
|
@me-no-dev any update on this? |
driver/sccb.c
Outdated
| @@ -6,6 +6,9 @@ | |||
| * SCCB (I2C like) driver. | |||
| * | |||
| */ | |||
|
|
|||
| #warning "legacy I2C API is deprecated, please use sccb-ng.c instead" | |||
There was a problem hiding this comment.
please remove this line. It will issue a warning on old IDF releases
|
@playduck sorry for the delay. Looks good with just one remark :) please fix it and I will merge it |
|
@me-no-dev No worries about the delay. I removed the warning. |
This PR removes the legacy I2C driver from the SCCB and implements the newer version (see issues #649 )
All interfaces outside the SCCB are entirely unchanged and identical!
I've tested the project with an OV2640 on an ESP32-Cam board - it functions identically.
To keep these identical I had to translate the unique i2c slave address to their distinctive
i2c_device_handle_t.This requires saving both of these in an array of a locally defined struct.
I'm not sure if this is an ideal solution moving forward but as it doesn't break anything outside of the SCCB I think this is reasonable (This whole translation thing is further explained in a comment from line 51 onwards)
Currently this requires the esp-idf head version (not the latest release), as the code makes heavy use of the
i2c_master_get_bus_handlefunction which is rather new (at the time of this PR).The use of this function isn't required and could be changed.
Also of note:
I've translated the functions
SCCB_Read16,SCCB_Write16,SCCB_Read_Addr16_Val16andSCCB_Write_Addr16_Val16as well. However it seems like these are entirely unused.Perhaps these could be removed?