8000 fix(libs): Allow for manual rebuilding and fix commit checking by lucasssvaz · Pull Request #245 · espressif/esp32-arduino-lib-builder · GitHub
[go: up one dir, main page]
Skip to content

fix(libs): Allow for manual rebuilding and fix commit checking #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix(libs): Allow for manual rebuilding and fix commit checking #245

merged 1 commit into from
Nov 18, 2024

Conversation

lucasssvaz
Copy link
Contributor

Description

Allows manually creating new libs without waiting for IDF commits.
Also use pagination to avoid issues with finding the IDF commit.

Testing

Tested in my fork

@lucasssvaz lucasssvaz self-assigned this Nov 15, 2024
@lucasssvaz lucasssvaz requested a review from me-no-dev November 15, 2024 21:43
me-no-dev
me-no-dev reviewed Nov 18, 2024
View reviewed changes
me-no-dev
me-no-dev reviewed Nov 18, 2024
View reviewed changes
@me-no-dev
Copy link
Member

in what cases will the libs be rebuilt?

@lucasssvaz
Copy link
Contributor Author

@me-no-dev me-no-dev merged commit 22ce681 into espressif:master Nov 18, 2024
2 of 8 checks passed
@lucasssvaz lucasssvaz deleted the fix/assets branch November 18, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

Assignees

@lucasssvaz lucasssvaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasssvaz @me-no-dev
0

in what cases will the libs be rebuilt?

It will work exactly as it does now with the addition of it always being rebuilt if we manually trigger it through the action tab.

image