8000 fix(ng): undefined reference in sdio_slave_api.c by MrSumi · Pull Request #606 · espressif/esp-hosted · GitHub
[go: up one dir, main page]
Skip to content

fix(ng): undefined reference in sdio_slave_api.c #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(ng): undefined reference in sdio_slave_api.c #606

wants to merge 1 commit into from

Conversation

MrSumi
Copy link
Contributor
@MrSumi MrSumi commented May 30, 2025

Description

Related

Testing

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mantriyogesh
Copy link
Collaborator

Thank you @MrSumi for your effort and time to create this pull request.

I understand you might have encountered the build failure, the root cause of this PR.

Can you please ammend the code:

--    if (len + offset > RX_BUF_SIZE) {
++    if (len + le16toh(header->offset) > RX_BUF_SIZE) {
        return -1;
    }

@MrSumi
Copy link
Contributor Author
MrSumi commented Jun 3, 2025

Thank you @MrSumi for your effort and time to create this pull request.

I understand you might have encountered the build failure, the root cause of this PR.

Can you please ammend the code:

--    if (len + offset > RX_BUF_SIZE) {
++    if (len + le16toh(header->offset) > RX_BUF_SIZE) {
        return -1;
    }

Hi, @mantriyogesh :
I think 'len' here is already included 'header->offset', plz check Line 404

@mantriyogesh
Copy link
Collaborator

Yes, you are absolutely right, apologies for oversight.

@Shreyas0-7 , Can we please take this PR?

@mantriyogesh
Copy link
Collaborator

code commit dfe0ff6 is pulled in @MrSumi . Thank you for patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrSumi @CLAassistant @mantriyogesh
0