Workaround strict-aliasing warnings#996
Merged
me-no-dev merged 1 commit intoespressif:masterfrom Jan 17, 2018
Lauszus:pgmspace
Merged
Workaround strict-aliasing warnings#996me-no-dev merged 1 commit intoespressif:masterfrom Lauszus:pgmspace
me-no-dev merged 1 commit intoespressif:masterfrom
Lauszus:pgmspace
Conversation
Contributor
|
@Lauszus looks like it works! Here is my test code: #include <pgmspace.h>
/* remove
8000
these comments to test new code
#undef pgm_read_word(addr)
#define pgm_read_word(addr) ({ \
typeof(addr) _addr = (addr); \
*(const unsigned short *)(_addr); \
})
*/
const PROGMEM uint16_t charSet[] = { 65000, 32796, 16843, 10, 11234};
const unsigned short sh=7;
void setup(){
unsigned short a = pgm_read_word(&sh);
Serial.begin(115200);
Serial.printf(" a =%d\n",a);
for(uint8_t b=0; b<(sizeof(charSet)/sizeof(uint16_t)); b++){
a = pgm_read_word(&charSet[b]);
Serial.printf(" a =%d\n",a);
}
}
void loop(){}output: with existing progmem output: with proposed changes to progmem Chuck. |
Member
|
merged :) |
Curclamas
pushed a commit
to Curclamas/arduino-esp32
that referenced
this pull request
Aug 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added missing pgm_read_ptr define
See: https://travis-ci.org/felis/USB_Host_Shield_2.0/jobs/328511332 and PaulStoffregen/cores@8a02ea6#diff-6e1ff9551639ac89d99617863bf84e10