Add brief explanation about app_main() function when arduino used as a esp-idf component #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me-no-dev
reviewed
Dec 14, 2016
| @@ -112,7 +112,8 @@ Linux 32/64, Linux ARM (like Raspberry Pi, BeagleBone, CubieBoard). | |||
| ``` | |||
| - Else you need to implement ```app_main()``` and call ```initArduino();``` in it. | |||
|
|
|||
| Keep in mind that setup() and loop() will not be called in this case | |||
| Keep in mind that setup() and loop() will not be called in this case. | |||
| If you are writing your code on esp-idf examples, make sure there is just app_main() function in your main.cpp and example files. | |||
There was a problem hiding this comment.
I'm not sure that this sentence is clear/correct. There could be much more than app_main in the main file. It needs to be clear that setup() and loop() are not running, so they should not be implemented and expected to be called.
The proposed sentence is restated in a more clear way.
Lzw655
pushed a commit
to Lzw655/arduino-esp32
that referenced
this pull request
Oct 12, 2023
* Added esp-insights to esp32 target build * Enabled coredump partition for esp-insights * Disabled ESP-Insights debug
brentru
pushed a commit
to adafruit/arduino-esp32
that referenced
this pull request
Oct 22, 2024
Adding Trinkeys
aIecxs
pushed a commit
to aIecxs/arduino-esp32
that referenced
this pull request
Oct 24, 2024
…a esp-idf component (espressif#99) * Add brief explanation about app_main() function * Update README.md The proposed sentence is restated in a more clear way. * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.