Update heltec_wifi v3 pins #7846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
P-R-O-C-H-Y
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Change
Update
heltec_wifi_kit_32_v3andheltec_wifi_kit_32_v3pin headers. @smerkadidit noticed that the pins were not correct for V3. This PR fixes that.This PR copies over changes from the upstream repo:
https://github.com/Heltec-Aaron-Lee/WiFi_Kit_series
Tests scenarios
I have both Heltec boards, and checked that the new pins were correct.
I also read through the pinout diagram, and schematic drawings for these boards to confirm the correct pins.
Related links
Fixes Issue #7737
This will also unblock these boards in platformio:
platformio/platform-espressif32#1018
See this merged PR for additional documentation, including links to DataSheets, Schematics and Reference manuals:
Heltec-Aaron-Lee/WiFi_Kit_series#163