Fix support for some arduino libraries which don't put source files under a src directory #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess you are using the core's libraries folder to store the libs for your sketches :) you could just add another component and do it there ;) Anyway :) I will merge this! Thanks |
Raienryu97
pushed a commit
to Raienryu97/arduino-esp32
that referenced
this pull request
Sep 4, 2017
…nder a src directory (espressif#605) * fix support for some arduino libraries * no longer need line 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many libraries which don't put their source files under src directory.
For example, nearly all sensor libraries from Adafruit don't have a src directory.
In order to compile with these libraries, we should manually create a src directory and move all source files into it, which is really annoying.
If the library also includes source files under sub directories, it would result in linker errors.
However, only changing a line in component.mk can solve all these issues.