8000 make BT core code execution conditional from include esp_bt.h by Jason2866 · Pull Request #11413 · espressif/arduino-esp32 · GitHub
[go: up one dir, main page]
Skip to content

make BT core code execution conditional from include esp_bt.h #11413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2025
Merged

make BT core code execution conditional from include esp_bt.h #11413

merged 3 commits into from
Jun 4, 2025

Conversation

Jason2866
Copy link
Collaborator
@Jason2866 Jason2866 commented May 30, 2025 •
edited
Loading

by this change it is possible to remove all not necessary BT include pathes. Why does this matter? The build system SCons which is used for pioarduino does not support @file in CPPPATH. This is a problem for Windows since command line limit is reached for big projects. The current approach to solve compile issues is to move the include files from CPPPATH to ASFLAGS and CCFLAGS and using with -iprefix. This approach generates a heavy performance decrease in compiling. To solve i am implementing a solution to keep the original correct way providing the includes via CPPPATH and remove the not needed includes. This works quiet well. Especially BT has a lot of includes, in most cases just removing this includes does solve Windows compile errors.

BUT currently removing the Bluetooth includes is not possible (even when BT is not used) because in the core file cores/esp32/esp32-hal-bt.c the include of esp_bt.h is always done. The PR changes that and only includes when the file is existing.

The PR does not change the standard behaviour and is fully backwards compatible.

Even when the change to NimBLE is done it should be checked for existing include files.
Only the compile settings are not enough to decide if the user code does use BT or not.

@me-no-dev please have a look and if possible merge for next release. All Windows pioarduino users will have a performance boost in compiling. Since the mentioned solution for removing not needed includes is ready.

 8000

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 30, 2025 •
edited
Loading
Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update esp32-hal-bt.c":
    • summary looks empty
    • type/action looks empty
  • the commit message "make code execution conditional from include esp_bt.h.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "only one if":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello Jason2866, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b1569b1

@Jason2866 Jason2866 changed the title make BT core code execution conditional from include esp_bt.h.h make BT core code execution conditional from include esp_bt.h May 30, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 30, 2025 •
edited
Loading

Test Results

 76 files   76 suites   12m 41s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit b1569b1.

♻️ This comment has been updated with latest results.

me-no-dev
me-no-dev reviewed May 30, 2025
View reviewed changes
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Jun 4, 2025
@me-no-dev me-no-dev merged commit 460b892 into espressif:master Jun 4, 2025
72 checks passed
@Jason2866 Jason2866 mentioned this pull request Jun 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jason2866 @me-no-dev
0