8000 Added new Unexpected Maker SQUiXL and EDGES3[D] boards. by UnexpectedMaker · Pull Request #11350 · espressif/arduino-esp32 · GitHub
[go: up one dir, main page]
Skip to content

Added new Unexpected Maker SQUiXL and EDGES3[D] boards. #11350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2025
Merged

Added new Unexpected Maker SQUiXL and EDGES3[D] boards. #11350

merged 3 commits into from
May 13, 2025

Conversation

UnexpectedMaker
Copy link
Contributor

Added support for 2 of my new boards: SQUiXL and EdgeS3[D]

Both ESP32-S3 boards.

Thanks :)

@UnexpectedMaker
Added new Unexpected Maker SQUiXL and EDGES3[D] boards.
2be618a 
Signed-off-by: Seon Rozenblum <seonr@3sprockets.com>
@CLAassistant
Copy link
CLAassistant commented May 11, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 11, 2025 •
edited
Loading
Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Added new Unexpected Maker SQUiXL and EDGES3[D] boards.":
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty
  • the commit message "Seems I have to have SPI pins defined for SQUiXL, or compiling breaks":
    • summary looks empty
    • type/action looks empty
  • the commit message "Seems we are being picky about board names now ;)":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello UnexpectedMaker, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against febd068

@UnexpectedMaker
Seems we are being picky about board names now ;)
2cf35b3 
Signed-off-by: Seon Rozenblum <seonr@3sprockets.com>
@UnexpectedMaker
Copy link
Contributor Author

It seems SQUiXL is failing your CI compile tests because it's trying to do tests with SPI - There is no SPI available to users on this board - so no SPI pins have been defined in arduino_pins.h - this is intentional, so I am not sure how to get past this issue.

Is this a real blocker @me-no-dev ?

Also, I've signed and confirmed the CLA - but it never changes to says I've signed.

Thanks :)

@UnexpectedMaker
Seems I have to have SPI pins defined for SQUiXL, or compiling breaks
febd068 
Signed-off-by: Seon Rozenblum <seon@unexpectedmaker.com>
@P-R-O-C-H-Y
Copy link
Member
P-R-O-C-H-Y commented May 12, 2025 •
edited
Loading

@UnexpectedMaker If you don't want to specify the SPI pins, you can set them as -1, but the SPI pins definition must exist :)
CLA seems to be fine.

@UnexpectedMaker
Copy link
Contributor Author

@UnexpectedMaker If you don't want to specify the SPI pins, you can set them as -1, but the SPI pins definition must exist :) CLA seems to be fine.

Oh, I didn't realize I could set them to -1 - I ended up adding IO assigned to them anyway :)

P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes May 12, 2025
View reviewed changes
Copy link
Member
@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label May 12, 2025
@me-no-dev me-no-dev merged commit 210edfe into espressif:master May 13, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UnexpectedMaker @CLAassistant @P-R-O-C-H-Y @me-no-dev
0