Added new Unexpected Maker SQUiXL and EDGES3[D] boards. #11350
Conversation
Signed-off-by: Seon Rozenblum <seonr@3sprockets.com>
|
|
👋 Hello UnexpectedMaker, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Signed-off-by: Seon Rozenblum <seonr@3sprockets.com>
|
It seems SQUiXL is failing your CI compile tests because it's trying to do tests with SPI - There is no SPI available to users on this board - so no SPI pins have been defined in arduino_pins.h - this is intentional, so I am not sure how to get past this issue. Is this a real blocker @me-no-dev ? Also, I've signed and confirmed the CLA - but it never changes to says I've signed. Thanks :) |
Signed-off-by: Seon Rozenblum <seon@unexpectedmaker.com>
|
@UnexpectedMaker If you don't want to specify the SPI pins, you can set them as -1, but the SPI pins definition must exist :) |
Oh, I didn't realize I could set them to -1 - I ended up adding IO assigned to them anyway :) |
Added support for 2 of my new boards: SQUiXL and EdgeS3[D]
Both ESP32-S3 boards.
Thanks :)