IDF master #10981
Merged
IDF master #10981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Some issues found for the commit messages in this PR:
"IDF master 1160a86b":Please fix these commit messages - here are some basic tips:
<type/action>(<scope/component>): <summary>, for examplefix(esp32): Fixed startup timeout issuechange,ci,docs,feat,fix,refactor,remove,revert,testTIP:Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).👋 Hello me-no-dev, we appreciate your contribution to this project!
📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each
pushevent to a Pull Request and modify the contents of this comment.Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
Review and merge process you can expect ...
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by 🚫 dangerJS against 03d9507
Uh oh!
There was an error while loading. Please reload this page.
Test Results
62 files 62 suites 6m 38s ⏱️
21 tests 21 ✅ 0 💤 0 ❌
153 runs 153 ✅ 0 💤 0 ❌
Results for commit 03d9507.
♻️ This comment has been updated with latest results.
IDF master 1160a86b7d3d8ccfix(ci): Do not compile RainMaker examples on ESP3203d95075f93a35to03d9507CompareMemory usage test (comparing PR against master branch)
The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
851280cinto release/v3.3.xUh oh!
There was an error while loading. Please reload this page.
IDF master (#10981)042015e