8000 analogSetPinAttenuation does not work with Board v1.0.5 and v1.0.6, but it works with board 1.0.4. How can i fix this problem? · Issue #5041 · espressif/arduino-esp32 · GitHub
[go: up one dir, main page]
Skip to content

analogSetPinAttenuation does not work with Board v1.0.5 and v1.0.6, but it works with board 1.0.4. How can i fix this problem? #5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cbkaefer opened this issue Apr 11, 2021 · 3 comments · Fixed by #5399
Closed

analogSetPinAttenuation does not work with Board v1.0.5 and v1.0.6, but it works with board 1.0.4. How can i fix this problem? #5041

cbkaefer opened this issue Apr 11, 2021 · 3 comments · Fixed by #5399
Assignees
@me-no-dev
Milestone
2.0.0

Comments

@cbkaefer
Copy link
cbkaefer commented Apr 11, 2021 •
edited
Loading

Hardware:
Board ESP32 Dev Module
Version/Date 1.0.6
IDE name Arduino IDE
Flash Frequency 80Mhz
PSRAM enabled no
Upload Speed 115200
Computer OS Windows 10

Description:

analogSetPinAttenuation does not work with Board v1.0.5 and v1.0.6, but it works with board 1.0.4.
There is no fault message, the compiler works with this code, but it takes no effect.
How can i fix this problem?

Sketch: (leave the backquotes for code formatting)

//Change the code below by your sketch
#include <Arduino.h>

void setup() {
analogSetPinAttenuation(34, ADC_0db);
adcAttachPin(34);
}

void loop() {
Serial.println(analogRead(34);
}
@Triangulix
Copy link

Looks like they completely broke the ADC API. Non-blocking reading is also gone.

@jesserockz jesserockz mentioned this issue Jun 25, 2021
Closed
@ssieb
Copy link
ssieb commented Jun 25, 2021 •
edited
Loading

There's a bug in #3377. It wipes out the attenuation setting every time you do a read.

@jesserockz
Copy link

Specifically a bug with

arduino-esp32/cores/esp32/esp32-hal-adc.c

Line 132 in 21947eb

__analogSetPinAttenuation(pin, __analogAttenuation);

being called every time the adc pin is attached to, which overrides the analogSetPinAttenuation called from the code above

@VojtechBartoska VojtechBartoska added the Status: Test needed Issue needs testing label Jul 14, 2021
@VojtechBartoska VojtechBartoska added this to the 2.0.0 milestone Jul 14, 2021
me-no-dev added a commit that referenced this issue Jul 16, 2021
@me-no-dev
Fix pin attenuation being overwritten
f81de7d 
Fixes: #5041
@me-no-dev me-no-dev mentioned this issue Jul 16, 2021
Merged
me-no-dev added a commit that referenced this issue Jul 16, 2021
@me-no-dev
Fix pin attenuation being overwritten (#5399)
a9bd39d 
Fixes: #5041
@agners agners mentioned this issue Jul 19, 2021
Merged
11 tasks
@proddy proddy mentioned this issue Jul 23, 2021
Closed
@VojtechBartoska VojtechBartoska removed the Status: Test needed Issue needs testing label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@me-no-dev me-no-dev

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Fix pin attenuation being overwritten espressif/arduino-esp32
6 participants
@ssieb @jesserockz @me-no-dev @Triangulix @VojtechBartoska @cbkaefer
0