fix sntp timezone #1266
Merged
fix sntp timezone #1266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to do a quick research, and got lost in code :) Git-blame shows this commit. If @OttoWinter can remember his ideas from 2018.
|
|
Ok thanks. I'm gonna merge this one. |
|
Not that the code Otto did was wrong. It worked okay until a recent change of Arduino code base. |
glmnet
added a commit
that referenced
this pull request
Sep 14, 2020
glmnet
added a commit
that referenced
this pull request
Sep 15, 2020
sashao
pushed a commit
to sashao/esphome
that referenced
this pull request
Oct 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
See also esphome/issues#1434
This is happening since Arduino 2.7.0 may be related: esp8266/Arduino#6993 Don't know exactly the cause but seems like the fix proposed by @f403 works reliable.
Actually a lot of code to review to find the reason, I find it easier to just test it and confirm the issue. If someone does a research job and finds root issue somewhere that's welcomed.
Related issue (if applicable): fixes esphome/issues#1434
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: