8000 Longer delays for Ticker and some internal updates by mcspr · Pull Request #8625 · esp8266/Arduino · GitHub
[go: up one dir, main page]
Skip to content

Longer delays for Ticker and some internal updates #8625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 1, 2022
Merged

Longer delays for Ticker and some internal updates #8625

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9100bac
Long delays in Ticker
mcspr Jun 30, 2022
80e9503
detach when not repeating
mcspr Jun 30, 2022
0a203d9
rotate
mcspr Jun 30, 2022
89fc3e8
restore static_assert
mcspr Jun 30, 2022
d06e4fc
cleanup, types
mcspr Jul 2, 2022
30acb52
no min check
mcspr Jul 2, 2022
e7f8699
persist
mcspr Jul 2, 2022
151c63d
syntax
mcspr Jul 2, 2022
07da13f
Merge remote-tracking branch 'origin/master' into ticker/longer-delay
mcspr Nov 1, 2022
4ad6781
optional tick instance
mcspr Nov 1, 2022
0843cbf
comments
mcspr Nov 1, 2022
8c0db60
less noisy
mcspr Nov 1, 2022
fc5b2a7
dont copy ticker obj
mcspr Nov 1, 2022
bd54953
detach() when copied or moved
mcspr Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
syntax
  • Loading branch information
@mcspr
mcspr committed Jul 2, 2022
commit 151c63d90d9ef88d21975e67fa97036b1d052f19
6 changes: 3 additions & 3 deletions libraries/Ticker/src/Ticker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,23 +202,23 @@ class Ticker
ETSTimer* _timer = nullptr;

private:
struct callback_ptr_t
{
// XXX undefined behaviour? fix next pr
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wcast-function-type"
struct callback_ptr_t
{
template <typename T>
callback_ptr_t(callback_with_typed_arg_t<T> func, T arg) :
func(reinterpret_cast<callback_with_arg_t>(func)),
arg(reinterpret_cast<void*>(arg))
#pragma GCC diagnostic pop
{
static_assert(sizeof(T) <= sizeof(void*), "attach() callback argument size must be <= sizeof(void*)");
}

callback_with_arg_t func = nullptr;
void* arg = nullptr;
};
#pragma GCC diagnostic pop

using callback_data_t = std::variant<
std::monostate,
Expand Down
0