8000 DHCP custom option by mcspr · Pull Request #8582 · esp8266/Arduino · GitHub
[go: up one dir, main page]
Skip to content

DHCP custom option #8582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 8, 2022
Merged

DHCP custom option #8582

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2ec527f
works
mcspr May 27, 2022
6ccb685
fixup! works
mcspr May 27, 2022
30b188e
back to callbacks
mcspr May 31, 2022
8c79b2b
names
mcspr May 31, 2022
729b732
daisy chain
mcspr May 31, 2022
cd91c14
Merge remote-tracking branch 'origin/master' into dhcps-opts
mcspr May 31, 2022
811bdf9
seconds
mcspr May 31, 2022
657c1e2
less inline
mcspr May 31, 2022
1010b86
fix dns setter
mcspr May 31, 2022
76a0f7e
might as well keep using initlist
mcspr May 31, 2022
fe425cb
shift blame
mcspr Jun 1, 2022
135fd4a
naming
mcspr Jun 1, 2022
3be2c6e
fix impl
mcspr Jun 1, 2022
2312b46
revert to ip4 dns
mcspr Jun 1, 2022
38c30cf
Merge remote-tracking branch 'origin/master' into dhcps-opts
mcspr Jun 2, 2022
8919f00
merge fix
mcspr Jun 2, 2022
ad7faf7
restyle
mcspr Jun 7, 2022
86b5dd5
Merge remote-tracking branch 'origin/master' into dhcps-opts
mcspr Jun 7, 2022
f9de275
masking done wrong
mcspr Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
might as well keep using initlist 
/to d-a-v it has automatic storage, here it's the same stack based one
(just one less line for us)
  • Loading branch information
@mcspr
mcspr committed May 31, 2022
commit 76a0f7ef79d813c17bbd51994c07d18801ffdaaf
17 changes: 7 additions & 10 deletions cores/esp8266/LwipDhcpServer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,24 +79,21 @@ class DhcpServer

OptionsBuffer& add(uint8_t code, uint8_t value)
{
uint8_t buffer[] { value };
return add(code, buffer, sizeof(buffer));
return add(code, { value });
}

OptionsBuffer& add(uint8_t code, uint16_t value)
{
uint8_t buffer[2] { static_cast<uint8_t>((value >> 8) & 0xff),
static_cast<uint8_t>(value & 0xff) };
return add(code, buffer, sizeof(buffer));
return add(code, { static_cast<uint8_t>((value >> 8) & 0xff),
static_cast<uint8_t>(value & 0xff) });
}

OptionsBuffer& add(uint8_t code, uint32_t value)
{
uint8_t buffer[4] { static_cast<uint8_t>((value >> 24) & 0xff),
static_cast<uint8_t>((value >> 16) & 0xff),
static_cast<uint8_t>((value >> 8) & 0xff),
static_cast<uint8_t>((value & 0xff)) };
return add(code, buffer, sizeof(buffer));
return add(code, { static_cast<uint8_t>((value >> 24) & 0xff),
static_cast<uint8_t>((value >> 16) & 0xff),
static_cast<uint8_t>((value >> 8) & 0xff),
static_cast<uint8_t>((value & 0xff)) });
}

OptionsBuffer& add(uint8_t code)
Expand Down
0