10000 WString: remove operator==(const __FlashStringHelper*) by d-a-v · Pull Request #8569 · esp8266/Arduino · GitHub
[go: up one dir, main page]
Skip to content

WString: remove operator==(const __FlashStringHelper*) #8569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 17, 2022
Merged

WString: remove operator==(const __FlashStringHelper*) #8569

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e15fc91
WString: overload ==
d-a-v May 16, 2022
a5cc344
keep only nullptr comparison overload
d-a-v May 16, 2022
e4b47bc
removing ==(FlashStringHelper) overload:
d-a-v May 16, 2022
a02c21c
restore the ==flashstringhelper overload, add ==decltype(NULL)
d-a-v May 16, 2022
bc52bd6
deprecate usage of NULL
d-a-v May 16, 2022
b912a70
Merge branch 'master' into streqeq
d-a-v May 17, 2022
65ad698
removing again ==(FlashStringHelper) overload
d-a-v May 17, 2022
fb666ef
revert changes about operator bool()
d-a-v May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removing again ==(FlashStringHelper) overload
  • Loading branch information
@d-a-v
d-a-v committed May 17, 2022
commit 65ad698ff2a002fd1de36eed2d5ed7b03ec650db
20 changes: 0 additions & 20 deletions cores/esp8266/WString.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,32 +226,12 @@ class String {
bool operator ==(const char *cstr) const {
return equals(cstr);
}
bool operator ==(const __FlashStringHelper *rhs) const {
return equals(rhs);
}
bool operator ==(std::nullptr_t) const {
return length() == 0;
}
[[deprecated("use nullptr instead of NULL")]]
bool operator ==(decltype(NULL)) const {
return length() == 0;
}
bool operator !=(const String &rhs) const {
return !equals(rhs);
}
bool operator !=(const char *cstr) const {
return !equals(cstr);
}
bool operator !=(const __FlashStringHelper *rhs) const {
return !equals(rhs);
}
bool operator !=(std::nullptr_t) const {
return length() != 0;
}
[[deprecated("use nullptr instead of NULL")]]
bool operator !=(decltype(NULL)) const {
return length() != 0;
}
bool operator <(const String &rhs) const;
bool operator >(const String &rhs) const;
bool operator <=(const String &rhs) const;
Expand Down
0