emulation on host: fix for latest changes in dnsserver #8559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcspr
reviewed
May 9, 2022
| @@ -1,5 +1,7 @@ | |||
| #ifndef DNSServer_h | |||
| #define DNSServer_h | |||
|
|
|||
| #include <memory> | |||
There was a problem hiding this comment.
future-proofing, I tried adding DNSServer/examples/DNSServer to host test script, but I see valgrind error in UDP code 🤷
something to note
| @@ -1,5 +1,7 @@ | |||
| #ifndef DNSServer_h | |||
| #define DNSServer_h | |||
|
|
|||
| #include <memory> | |||
There was a problem hiding this comment.
future-proofing, I tried adding DNSServer/examples/DNSServer to host test script, but I see valgrind error in UDP code 🤷
something to note
There was a problem hiding this comment.
Is there a line number to go with that?
There was a problem hiding this comment.
Also mocking. ~DNSServer -> ~WiFiUDP -> UdpContext.disconnect() tries to delete std::map entry, which may or may not be already destroyed (?).
Not related to the DNSServer, but to the way UDP is organized there.
|
With this change: --- a/libraries/DNSServer/examples/DNSServer/DNSServer.ino
+++ b/libraries/DNSServer/examples/DNSServer/DNSServer.ino
@@ -1,5 +1,5 @@
-#include <ESP8266WiFi.h>
#include <DNSServer.h>
+#include <ESP8266WiFi.h>
#include <ESP8266WebServer.h>This happens: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.